NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Fixed parsing deprecated definitions without message key#40541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:5.2fromadamwojs:undefined_index_message

Mar 23, 2021

Merged

Fixed parsing deprecated definitions without message key#40541

nicolas-grekas merged 1 commit intosymfony:5.2fromadamwojs:undefined_index_message

Mar 23, 2021

Conversation

Copy link

Contributor

adamwojs commentedMar 22, 2021

Q	A
Branch?	5.2
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	-
License	MIT
Doc PR	-

Steps to reproduce

Create service/alias definition and mark it as deprecated without specifying message key as shown inhttps://symfony.com/doc/5.2/service_container/alias_private.html#deprecating-service-aliases. For example:

services:service_without_deprecation_message:class:Foodeprecated:package:vendor/packageversion:1.1alias_without_deprecation_message:alias:foobardeprecated:package:vendor/packageversion:1.1

Clear cache by runningphp bin/console cache:clear

Actual behaviour

Symfony\Component\Config\Exception\LoaderLoadException exception is thrown with the following message:Warning: Undefined array key "message" (...)

Seehttps://gist.github.com/adamwojs/5bac85d4326d8fbe6f52a357fa6e57e6 for full stactrace.

Excepted behaviour

Given definitions are loaded correctly. Default service/alias deprecation message is used as shown in linked documentation page.

Fixed parsing deprecated definitions without message key

d585b64

carsonbot added Status: Needs Review Bug labels

Mar 22, 2021

carsonbot added this to the5.2 milestone

Mar 22, 2021

Copy link

carsonbot commentedMar 22, 2021

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

adamwojs changed the title~~Fixed parsing deprecated definitions without message key~~[DependencyInjection] Fixed parsing deprecated definitions without message key

Mar 22, 2021

Copy link

carsonbot commentedMar 23, 2021

Hey!

I had a quick look at this PR, I think it is alright.

I think@mtarld has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

nicolas-grekas approved these changes

Mar 23, 2021

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Mar 23, 2021

carsonbot changed the title~~[DependencyInjection] Fixed parsing deprecated definitions without message key~~Fixed parsing deprecated definitions without message key

Mar 23, 2021