NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[HttpKernel] ConfigDataCollector to return known data without the need of a Kernel#40535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Nyholm merged 1 commit intosymfony:4.4fromtopikito:kernel-lts-4.4

Mar 25, 2021

Merged

[HttpKernel] ConfigDataCollector to return known data without the need of a Kernel#40535

Nyholm merged 1 commit intosymfony:4.4fromtopikito:kernel-lts-4.4

Mar 25, 2021

Conversation

Copy link

Contributor

topikito commentedMar 21, 2021•
edited
Loading

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#40534
License	MIT
Doc PR

Sets$this->data with information that can be known without the need of aKernel.

carsonbot added Status: Needs Review Bug HttpKernel labels

Mar 21, 2021

carsonbot added this to the4.4 milestone

Mar 21, 2021

Copy link

carsonbot commentedMar 21, 2021

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link

Member

derrabus commentedMar 22, 2021

How is it possible that we getnull here in the first place? Shouldn't we always be able to determine that piece of information?

Copy link

Contributor

ciaranmcnulty commentedMar 22, 2021

@derrabus Not when this condition is false

symfony/src/Symfony/Component/HttpKernel/DataCollector/ConfigDataCollector.php

Lines 81 to 93 inb5693be

	if (isset($this->kernel)) {
	foreach ($this->kernel->getBundles()as$name =>$bundle) {
	$this->data['bundles'][$name] =newClassStub(\get_class($bundle));
	}

	$this->data['symfony_state'] =$this->determineSymfonyState();
	$this->data['symfony_minor_version'] =sprintf('%s.%s', Kernel::MAJOR_VERSION, Kernel::MINOR_VERSION);
	$this->data['symfony_lts'] =4 === Kernel::MINOR_VERSION;
	$eom = \DateTime::createFromFormat('d/m/Y','01/'.Kernel::END_OF_MAINTENANCE);
	$eol = \DateTime::createFromFormat('d/m/Y','01/'.Kernel::END_OF_LIFE);
	$this->data['symfony_eom'] =$eom->format('F Y');
	$this->data['symfony_eol'] =$eol->format('F Y');
	}

fabpot requested changes

Mar 22, 2021

View reviewed changes

src/Symfony/Component/HttpKernel/DataCollector/ConfigDataCollector.php OutdatedShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Mar 22, 2021

Copy link

Contributor

ro0NL commentedMar 22, 2021

we should only rely on the$this->kernel instance for bundle aggregration IMHO.

then always get remaining metadata from staticKernel symbol (which is a hard dep)

Copy link

ContributorAuthor

topikito commentedMar 22, 2021

I have suggested a different solution as to the suggestion of@fabpot to returnfalse: bring out of theif block all assignments that rely onKernel and not on$kernel.

#40535 (comment)

Copy link

ContributorAuthor

topikito commentedMar 22, 2021

I have extracted the corresponding bits outside of theif block.

For the tests, I decided to add extra checks for all the content I extracted. I required a way to generate the same output fordetermineSymfonyState() so I decided to copy the behaviour. The reason behind this is that I assume it's not desired to rewrite the tests for each version, so it should rather expect to have the same logic in the tests. If the logic in the class would change, the test should catch it. If this is not acceptable, please let me know how to proceed to test that particular getter.

stof reviewed

Mar 23, 2021

View reviewed changes

src/Symfony/Component/HttpKernel/Tests/DataCollector/ConfigDataCollectorTest.php OutdatedShow resolvedHide resolved

Copy link

Member

nicolas-grekas commentedMar 23, 2021

The descrition+title of the PR need an update now ;)

topikito requested a review fromstof

March 23, 2021 12:33

carsonbot added Status: Needs Review and removed Status: Needs Work labels

Mar 23, 2021

topikito requested review fromfabpot andnicolas-grekas

March 23, 2021 12:33

topikito changed the title~~[HttpKernel] Add nullable return type on isSymfonyLts()~~[HttpKernel] ConfigDataCollector to return known data without the need of a Kernel

Mar 23, 2021