Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Translation] Missing translations from traits#40529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4frominsekticid:patch-1
Jul 4, 2021

Conversation

@insekticid
Copy link
Contributor

@insekticidinsekticid commentedMar 20, 2021
edited by nicolas-grekas
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#40528
LicenseMIT
Doc PRsymfony/symfony-docs#...

If you use ->trans() in traits, your translations will be cleaned with translation:update --clean command

Affected all Symfony versions

Please write some tests for me, I took me long time to debug and repair this :(

image

@carsonbotcarsonbot changed the titleMissing translations from traits[Translation] Missing translations from traitsMar 20, 2021
@stof
Copy link
Member

Please add tests covering this, to prevent regressions

@fabpot
Copy link
Member

Thank you@insekticid.

@fabpotfabpot merged commita224fa7 intosymfony:4.4Jul 4, 2021
This was referencedJul 26, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@jderussejderusseAwaiting requested review from jderusse

@lyrixxlyrixxAwaiting requested review from lyrixx

@srozesrozeAwaiting requested review from sroze

@wouterjwouterjAwaiting requested review from wouterj

@xabbuhxabbuhAwaiting requested review from xabbuh

@ycerutoycerutoAwaiting requested review from yceruto

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

[Translation] - translation:update command does not extract from traits

6 participants

@insekticid@stof@fabpot@nicolas-grekas@Nyholm@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp