Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Serializer] Allow AbstractNormalizer to use null for non-optional nullable constructor parameters without default value#40522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
pounard commentedMar 19, 2021
Build failure seems to be unrelated, am I misreading it ? |
src/Symfony/Component/Serializer/Tests/Normalizer/AbstractNormalizerTest.phpShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Serializer/Tests/Fixtures/NullableOptionalConstructorArgumentDummy.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
pounard commentedMar 22, 2021
@ro0NL@nicolas-grekas thank you. I hope it will land in next 5.2 release, I have to maintain a patch in the meantime. |
…constructor parameter denormalization when not present in input
nicolas-grekas commentedMar 22, 2021
I rebased on 4.4, where bugfixes should be merged. |
pounard commentedMar 22, 2021
Oh, nice ! Thank you very much. |
chalasr commentedMar 29, 2021
Thank you@pounard. |
…listed in the input (Christian Kolb)This PR was merged into the 6.3 branch.Discussion----------[Serializer] Add flag to require all properties to be listed in the input| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets |Fix#49504| License | MIT| Doc PR |symfony/symfony-docs#17979The PR#40522 introduced a fallback for nullable properties to be set to `null` when they aren't provided as parameters.A drawback of that approach is that it easier for bugs to appear through typos or renamings of those properties. I think the current implementation makes perfect sense as a default. Therefore, this PR introduces a new context flag that prevents that fallback behaviour. This way nothing changes for existing systems, but for people wanting more control, it's possible to set a flag.### Example```phpfinal class Product{ public function __construct( public string $name, public ?int $costsInCent, ) { }}// This works and results in $costsInCent as null$product = $this->serializer->deserialize( '{"name": "foo"}', Product::class, JsonEncoder::FORMAT,);// When using the flag, only the following JSON is valid$product = $this->serializer->deserialize( '{"name": "foo", "costsInCent": null}', Product::class, JsonEncoder::FORMAT, [ AbstractNormalizer::PREVENT_NULLABLE_FALLBACK => true, ],);// This would result in an error due to missing parameters$product = $this->serializer->deserialize( '{"name": "foo"}', Product::class, JsonEncoder::FORMAT, [ AbstractNormalizer::PREVENT_NULLABLE_FALLBACK => true, ],);```Commits-------d62410a [Serializer] Add flag to require all properties to be listed in the input
Uh oh!
There was an error while loading.Please reload this page.
Serializer component AbstractNormalizer attemps to guess constructor parameters, and falls back using default values when possible. Yet, it misses one use case: nullable non-optional parameter with value not being present in incoming input, case in which null is a valid value, not the default one, yet still valid.
This PR introduce a two-line fix that forcefully set null as value for missing from input non-optional nullable constructor parameters values.