Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] IntegerType: Always use en for IntegerToLocalizedStringTransformer#40510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
xabbuh merged 1 commit intosymfony:4.4fromWarxcell:fixes_40456
Mar 26, 2021

Conversation

@Warxcell
Copy link
Contributor

Fixes#40456

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#40456
LicenseMIT

@carsonbotcarsonbot added this to the4.4 milestoneMar 18, 2021
@WarxcellWarxcellforce-pushed thefixes_40456 branch 2 times, most recently from884f74f tobafdf4bCompareMarch 18, 2021 13:37
@WarxcellWarxcell changed the titleIntegerType: Always use en for IntegerToLocalizedStringTransformer[Form] IntegerType: Always use en for IntegerToLocalizedStringTransformerMar 18, 2021
Copy link
Member

@derrabusderrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for your contribution. Can you please add a test for your changes?

@carsonbotcarsonbot changed the title[Form] IntegerType: Always use en for IntegerToLocalizedStringTransformerIntegerType: Always use en for IntegerToLocalizedStringTransformerMar 18, 2021
@Warxcell
Copy link
ContributorAuthor

Warxcell commentedMar 18, 2021•
edited
Loading

Thank you for your contribution. Can you please add a test for your changes?

Where are tests for this FormType and Transformer? I don't see them.

Nvm, found them.

@WarxcellWarxcellforce-pushed thefixes_40456 branch 3 times, most recently fromb413f1b to68ad1bcCompareMarch 18, 2021 15:27
@WarxcellWarxcell requested a review fromderrabusMarch 18, 2021 15:28
@xabbuhxabbuh added the Form labelMar 18, 2021
@carsonbotcarsonbot changed the titleIntegerType: Always use en for IntegerToLocalizedStringTransformer[Form] IntegerType: Always use en for IntegerToLocalizedStringTransformerMar 18, 2021
@WarxcellWarxcellforce-pushed thefixes_40456 branch 2 times, most recently from957265a to382fbb4CompareMarch 18, 2021 15:40
@xabbuh
Copy link
Member

Thank you@Warxcell.

@xabbuhxabbuh merged commitd0875a9 intosymfony:4.4Mar 26, 2021
@WarxcellWarxcell deleted the fixes_40456 branchMarch 26, 2021 14:53
This was referencedMar 29, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh approved these changes

@ycerutoycerutoyceruto approved these changes

@derrabusderrabusAwaiting requested review from derrabus

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@Warxcell@xabbuh@derrabus@yceruto@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp