Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Yaml] fix parsing some block sequences#40503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4froma1812:bug#40438
Apr 1, 2021

Conversation

@a1812
Copy link
Contributor

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#40438
LicenseMIT
Doc PR

@a1812a1812 requested a review fromxabbuh as acode ownerMarch 17, 2021 18:20
@carsonbotcarsonbot added this to the4.4 milestoneMar 17, 2021
@nicolas-grekasnicolas-grekas changed the titleBug#40438[Yaml] parses some block sequencesMar 17, 2021
@nicolas-grekasnicolas-grekas changed the title[Yaml] parses some block sequences[Yaml] fix parsing some block sequencesMar 17, 2021
@carsonbotcarsonbot changed the title[Yaml] fix parsing some block sequencesfix parsing some block sequencesMar 17, 2021
@a1812a1812 changed the titlefix parsing some block sequences[Yaml] fix parsing some block sequencesMar 18, 2021
@a1812a1812force-pushed thebug#40438 branch 2 times, most recently from56f32f5 to590c94fCompareMarch 23, 2021 01:51
@a1812
Copy link
ContributorAuthor

Hi@xabbuh please check my super code :)

@xabbuh
Copy link
Member

xabbuh commentedMar 26, 2021
edited
Loading

Wow, this looks great@a1812! 👍 I have some suggestions how to simplify the patch a bit. Please take a look ata1812#1 if you agree with them.

a1812 reacted with thumbs up emoji

@carsonbotcarsonbot changed the title[Yaml] fix parsing some block sequencesfix parsing some block sequencesMar 26, 2021
@carsonbotcarsonbot changed the titlefix parsing some block sequences[Yaml] fix parsing some block sequencesApr 1, 2021
@nicolas-grekas
Copy link
Member

Thank you@a1812.

@fabpotfabpot mentioned this pull requestMay 1, 2021
@a1812a1812 deleted the bug#40438 branchJuly 21, 2021 10:49
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@xabbuhxabbuhxabbuh approved these changes

+1 more reviewer

@stloydstloydstloyd requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

6 participants

@a1812@xabbuh@nicolas-grekas@stloyd@OskarStark@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp