Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Inflector][String] Fixed pluralize "coupon"#40499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4fromNyholm:coupon
Mar 17, 2021

Conversation

@Nyholm
Copy link
Member

@NyholmNyholm commentedMar 17, 2021•
edited by nicolas-grekas
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#40467
LicenseMIT
Doc PR

The rule for "bacteria (bacterium), criteria (criterion), phenomena (phenomenon)" is producing this behaviour. I added an exception to the "criterion exception".

"coupon" is an old French word, that is maybe why it does not follow the classic "on" rule... I dont know. The test passes and I dont think I've added any side-effects.

This is also my first time working with theEnglishInflector.

derrabus reacted with thumbs up emoji
@derrabus
Copy link
Member

This issue needs to be fixed on 4.4 (inflector component).

@derrabusderrabus modified the milestones:5.2,4.4Mar 17, 2021
@carsonbotcarsonbot changed the title[String] Fixed pluralize "coupon"[Inflector][String] Fixed pluralize "coupon"Mar 17, 2021
@NyholmNyholm changed the base branch from5.2 to4.4March 17, 2021 15:36
@Nyholm
Copy link
MemberAuthor

You are correct. The bug existed in 4.4 in the inflector component too. I guess it will be merged up properly if I target 4.4.

The PR is updated.

derrabus reacted with thumbs up emoji

['noi',3,true,true,'ions'],

// coupon (coupons)
['nopuoc',6,true,true,'coupons'],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

maybe we can widen this to
['nop', 3, true, true, 'pons'],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I confirm we should do this, seehttps://en.wiktionary.org/wiki/Category:English_plurals_ending_in_%22-a%22: it lists no English words that end withpon and have apa plural.

derrabus reacted with thumbs up emoji
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(updated)

@nicolas-grekas
Copy link
Member

Thank you@Nyholm.

@nicolas-grekasnicolas-grekas merged commitd3c0834 intosymfony:4.4Mar 17, 2021
@Nyholm
Copy link
MemberAuthor

Thank you for merging.

@NyholmNyholm deleted the coupon branchMarch 18, 2021 08:03
This was referencedMar 29, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@derrabusderrabusderrabus approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@Nyholm@derrabus@nicolas-grekas@javiereguiluz@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp