Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpFoundation] enable HTTP method overrides as early as possible with the HTTP cache#40497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.2fromxabbuh:issue-40452
Mar 18, 2021

Conversation

@xabbuh
Copy link
Member

@xabbuhxabbuh commentedMar 17, 2021•
edited
Loading

QA
Branch?5.2
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#40452
LicenseMIT
Doc PR

@nicolas-grekas
Copy link
Member

I don't think we should do this on 4.4. On 4.4, it should be ppl's job to call the method early enough.

On 5.2, we should call the method when constructing thehttp_cache service.

@xabbuhxabbuh changed the base branch from4.4 to5.2March 17, 2021 20:18
@xabbuhxabbuh changed the title[HttpFoundation] detect changes of $httpMethodParameterOverride after calling getMethod()[FrameworkBundle] enable HTTP method overrides as early as possible with the HTTP cacheMar 17, 2021
@xabbuhxabbuh modified the milestones:4.4,5.2Mar 17, 2021
@xabbuh
Copy link
MemberAuthor

I think you are right. This also fixes the cache key issue.

@carsonbotcarsonbot changed the title[FrameworkBundle] enable HTTP method overrides as early as possible with the HTTP cache[HttpFoundation] enable HTTP method overrides as early as possible with the HTTP cacheMar 18, 2021
@fabpot
Copy link
Member

Thank you@xabbuh.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

5 participants

@xabbuh@nicolas-grekas@fabpot@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp