Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Bridge\Twig] Add 'form-control-range' for range input type#40472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4fromOviglo:bootstrap-range-input-fix
Mar 16, 2021
Merged

[Bridge\Twig] Add 'form-control-range' for range input type#40472

nicolas-grekas merged 1 commit intosymfony:4.4fromOviglo:bootstrap-range-input-fix
Mar 16, 2021

Conversation

@Oviglo
Copy link
Contributor

@OvigloOviglo commentedMar 15, 2021
edited
Loading

QA
Branch?5.x
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Add 'form-control-range' for range input type for Bootstrap theme,see the doc

mynameisbogdan reacted with thumbs up emoji
Copy link
Contributor

@AngelFQCAngelFQC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi@Oviglo

Me, again :)

In this pull request you are mixing minor changes (like format of code) and logical changes

From the documentation, herehttps://symfony.com/doc/current/contributing/code/pull_requests.html#work-on-your-pull-request
There are three points to consider:

  • Do atomic and logically separate commits (use the power of git rebase to have a clean and logical history);
  • Never fix coding standards in some existing code as it makes the code review more difficult;
  • Write good commit messages: Start by a short subject line (the first line), followed by a blank line and a more detailed

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, just minor comments. That's for 4.4 I guess.

@nicolas-grekasnicolas-grekas added this to the4.4 milestoneMar 16, 2021
@nicolas-grekasnicolas-grekas changed the titleAdd 'form-control-range' for range input type.[Bridge\Twig] Add 'form-control-range' for range input typeMar 16, 2021
@nicolas-grekas
Copy link
Member

Thank you@Oviglo.

Oviglo reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas merged commitff9c815 intosymfony:4.4Mar 16, 2021
This was referencedMar 29, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@jderussejderusseAwaiting requested review from jderusse

@lyrixxlyrixxAwaiting requested review from lyrixx

@srozesrozeAwaiting requested review from sroze

@wouterjwouterjAwaiting requested review from wouterj

@xabbuhxabbuhAwaiting requested review from xabbuh

@ycerutoycerutoAwaiting requested review from yceruto

+1 more reviewer

@AngelFQCAngelFQCAngelFQC left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@Oviglo@nicolas-grekas@AngelFQC@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp