Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Bridge\Twig] Add 'form-control-range' for range input type#40472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
AngelFQC left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hi@Oviglo
Me, again :)
In this pull request you are mixing minor changes (like format of code) and logical changes
From the documentation, herehttps://symfony.com/doc/current/contributing/code/pull_requests.html#work-on-your-pull-request
There are three points to consider:
- Do atomic and logically separate commits (use the power of git rebase to have a clean and logical history);
- Never fix coding standards in some existing code as it makes the code review more difficult;
- Write good commit messages: Start by a short subject line (the first line), followed by a blank line and a more detailed
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks, just minor comments. That's for 4.4 I guess.
src/Symfony/Bridge/Twig/Tests/Extension/AbstractBootstrap4LayoutTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
nicolas-grekas commentedMar 16, 2021
Thank you@Oviglo. |
Uh oh!
There was an error while loading.Please reload this page.
Add 'form-control-range' for range input type for Bootstrap theme,see the doc