Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Console] ProgressBar clears too many lines on update#40450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@danepowell
Copy link
Contributor

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
LicenseMIT

The ProgressBar incorrectly calculates line lengths when updating, including non-displayable characters such as ANSI colors. This causes it to clear too many lines if the terminal width is greater than the displayed line length but less than the line length including non-displayed characters. An example of this bug in action ishttps://github.com/acquia/cli/issues/467

@danepowell
Copy link
ContributorAuthor

I don't see how the test failures are related to this PR, let me know if anything else is needed

@fabpot
Copy link
Member

Can you add a test to cover this bug?

@grasmash
Copy link
Contributor

I can reproduce the bug with a small terminal window. I can confirm via a manual test that the upstream change does resolve the issue.

@danepowelldanepowellforce-pushed theprogressbar-clears-lines branch fromf17a75b to159bd27CompareMarch 12, 2021 19:02
@danepowell
Copy link
ContributorAuthor

I added a unit test. You can see it failing in thetest-only commit and thenpassing after the fix.

(both commits fail the full test suite due to some unrelated issue on the 4.4 branch)

@nicolas-grekasnicolas-grekas changed the titleProgressBar clears too many lines on update[Console] ProgressBar clears too many lines on updateMar 16, 2021
@nicolas-grekas
Copy link
Member

Thank you@danepowell.

@nicolas-grekasnicolas-grekas merged commita78fb18 intosymfony:4.4Mar 16, 2021
This was referencedMar 29, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

6 participants

@danepowell@fabpot@grasmash@nicolas-grekas@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp