NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[DoctrineBridge] Fix eventListener initialization when eventSubscriber constructor dispatch an event#40425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:4.4fromjderusse:fix-event-subscriber

Mar 10, 2021

Merged

[DoctrineBridge] Fix eventListener initialization when eventSubscriber constructor dispatch an event#40425

fabpot merged 1 commit intosymfony:4.4fromjderusse:fix-event-subscriber

Mar 10, 2021

Conversation

Copy link

Member

jderusse commentedMar 9, 2021•
edited
Loading

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#40365
License	MIT
Doc PR	-

The issue occurred, when an EventSubscriber (lazyLoaded) dispatch an event when constructed. In that case, the state of theContainerAwareEventManager become inconsistent for the triggered event:

thelistener property contains both listener instance andserviceId meaning it's not fully initialized
theinitialized property containstrue meaning the listeners are initialized

Sorry for this PR without test, But it's really to hard to reproduce the issue :(

@parijke @michanismus @fliespl @reypm could you please check if this patch fixes the issue for you?

carsonbot added Status: Needs Review Bug labels

Mar 9, 2021

carsonbot added this to the4.4 milestone

Mar 9, 2021

jderusse changed the title~~Fix eventListener initialization when eventSubscriber constructor dis…~~Fix eventListener initialization when eventSubscriber constructor dispatch an event

Mar 9, 2021

jderusse modified the milestone:4.4

Mar 9, 2021

jderusse added the DoctrineBridge label

Mar 9, 2021

carsonbot changed the title~~Fix eventListener initialization when eventSubscriber constructor dispatch an event~~[DoctrineBridge] Fix eventListener initialization when eventSubscriber constructor dispatch an event

Mar 9, 2021

Fix eventListener initialization when eventSubscriber constructor dis…

b3ee292

…patch an event

jderusse force-pushed thefix-event-subscriber branch from6564d7a tob3ee292Compare

March 9, 2021 16:20

Copy link

reypm commentedMar 9, 2021•
edited
Loading

@jderusse steps followed:

composer update "symfony/*" --with-all-dependencies
bin/console clear:cache &&bin/console clear:cache --env=test

$ bin/console cache:clear // Clearing the cache for the local environment with debug true                                                                                                                                                                                [OK] Cache for the "local" environment (debug=true) was successfully cleared.                                                                                                                                                                  $ bin/console cache:clear --env=test // Clearing the cache for the test environment with debug true                                                                                                                                                                           [OK] Cache for the "test" environment (debug=true) was successfully cleared.