Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Add 'form-control-range' for range input type#40422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Add 'form-control-range' for range input type.
Apudate bootstrap range test
Oviglo commentedMar 9, 2021
I finished my 4 month old pull request:#38625 |
carsonbot commentedMar 10, 2021
Hey! Excellent, just like I would have done it. I think@AngelFQC has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
Oviglo commentedMar 10, 2021
Yes there are some failed builds and I don't know to fix that (it's my first pull request) |
AngelFQC left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This fails when generating trailing spaces, for example here:
Expected-'<input type="text" name="text" disabled="disabled" required="required" readonly="readonly" maxlength="10" pattern="\d+" data-foo="bar" value="value" />'Actual+' <input type="text" name="text" disabled="disabled" required="required" readonly="readonly" maxlength="10" pattern="\d+" data-foo="bar" value="value" />'Uh oh!
There was an error while loading.Please reload this page.
AngelFQC commentedMar 12, 2021
@Oviglo maybe you need follow the instructions to rebase your code according tohttps://symfony.com/doc/current/contributing/code/pull_requests.html#step-4-submit-your-pull-request and pass the fabbot.io check |
Add 'form-control-range' for range input type.
Apudate bootstrap range test
Add 'form-control-range' for range input type.