Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
FixConstraintViolation#getMessageTemplate() to always returnstring#40416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:5.2fromOcramius:fix/ensure-message-template-respects-declared-interface-typeMar 11, 2021
Merged
FixConstraintViolation#getMessageTemplate() to always returnstring#40416
fabpot merged 1 commit intosymfony:5.2fromOcramius:fix/ensure-message-template-respects-declared-interface-typeMar 11, 2021
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
carsonbot commentedMar 9, 2021
Hey! Well done!, Im impressed by this PR. I think@mdlutz24 has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
derrabus approved these changesMar 10, 2021
fabpot approved these changesMar 10, 2021
cb47a35 tof6e9132CompareMember
fabpot commentedMar 10, 2021
Can you rebase on the 5.2 branch (I cannot do it for you as I cannot push to your branch). Thank you. |
`ConstraintViolation#getMessageTemplate()`'s inherited signature states that `string` isto be returned by it at all times, yet the implementation returns `null` when no messagetemplate had been provided at instantiation.This patch obviates it, returning an empty string when themessage template is `null`.Ref:symfony#40415 (comment)
f6e9132 to72a464eComparexabbuh approved these changesMar 11, 2021
Member
fabpot commentedMar 11, 2021
Thank you@Ocramius. |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConstraintViolation#getMessageTemplate()'s inherited signature states thatstringisto be returned by it at all times, yet the implementation returns
nullwhen no messagetemplate had been provided at instantiation.
This patch obviates it, returning an empty string when the
message template is
null.Ref:#40415 (comment)