Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Fix PropertyAccess definition when not in debug#40313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[FrameworkBundle] Fix PropertyAccess definition when not in debug#40313
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedFeb 26, 2021
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
fabpot commentedMar 9, 2021
Thank you@PedroTroller. |
…n not in debug (PedroTroller)This PR was merged into the 4.4 branch.Discussion----------[FrameworkBundle] Fix PropertyAccess definition when not in debug| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| Deprecations? | no| License | MITThe signature of the `PropertyAccessor::createCache()` method specifies that the first argument must be a string but in the `FameworkBundle` configures its DIC with a first argument to `null`. Replacing `null` by `''` allows to respect the contact of `PropertyAccessor::createCache()` and removes the following error when the `symfony/framework-bundle` is blocked in `4.4` but the symfony/property-access goes up to `5.2`.```Argument 3 passed to Symfony\Component\PropertyAccess\PropertyAccessor::createCache() must be of the type string, null given, called in /usr/src/app/var/cache/prod/ContainerDX7KWI4/getCache_PropertyAccessService.php on line 12```Commits-------116c54a Fix FrameworkBundle PropertyAccess definition when not in debug
Uh oh!
There was an error while loading.Please reload this page.
The signature of the
PropertyAccessor::createCache()method specifies that the first argument must be a string but in theFrameworkBundleconfigures its DIC with a first argument tonull. Replacingnullby''allows to respect the contact ofPropertyAccessor::createCache()and removes the following error when thesymfony/framework-bundleis blocked in4.4but the symfony/property-access goes up to5.2.