NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[ErrorHandler] Fix error caused by`include` + open_basedir#40242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:5.2fromstlrnz:error-template

Mar 16, 2021

Merged

[ErrorHandler] Fix error caused by`include` + open_basedir#40242

nicolas-grekas merged 1 commit intosymfony:5.2fromstlrnz:error-template

Mar 16, 2021

Conversation

Copy link

Contributor

stlrnz commentedFeb 18, 2021

Q	A
Branch?	5.2
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets
License	MIT
Doc PR

#37492 introduced the option to specify your own error template usingHtmlErrorRenderer::setTemplate('...');

However, the implementation usingfile_exists(...) ininclude can cause an error when not setting a custom template.

php.WARNING: Warning: file_exists(): open_basedir restriction in effect. File(assets/css/error.css) is not within the allowed path(s): (...) {"exception":"[object] (ErrorException(code: 0): Warning: file_exists(): open_basedir restriction in effect. File(assets/css/error.css) is not within the allowed path(s): (...) at ...\vendor\symfony\error-handler\ErrorRenderer\HtmlErrorRenderer.php:355)"} []

As you can see the error is caused by checkingfile_exists(...) using relative paths in environments with a restrictiveopen_basedir policy.

The proposed solution always uses absolute paths to include errors templates (and other files).

stlrnz requested a review fromyceruto as acode owner

February 18, 2021 14:45

carsonbot added Status: Needs Review Bug ErrorHandler labels

Feb 18, 2021

Copy link

carsonbot commentedFeb 18, 2021

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot