Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Console] fix QuestionHelper::getHiddenResponse() not working with space in project directory name#40192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
chalasr merged 1 commit intosymfony:4.4fromYendric:patch-1
Feb 16, 2021

Conversation

@Yendric
Copy link
Contributor

@YendricYendric commentedFeb 14, 2021•
edited by OskarStark
Loading

QA
Branch?5.2
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#40190
LicenseMIT
Doc PRsymfony/symfony-docs#...

Fixes#40190 to allow spaces in project directory name.

@Nyholm
Copy link
Member

Do you think it is possible to add a test for this feature? That would make sure we never reintroduce this bug again.

@nicolas-grekasnicolas-grekas changed the title[Console] Fix #40190[Console] fix QuestionHelper::getHiddenResponse() not working with space in project directory nameFeb 16, 2021
@nicolas-grekas
Copy link
Member

nicolas-grekas commentedFeb 16, 2021•
edited
Loading

@Nyholm Adding a test case is going to be tricky as this means installing the package in a directory with a space before launching the tests. We cannot isolate this in a simple test case...

@chalasrchalasr modified the milestones:5.2,4.4Feb 16, 2021
@chalasr
Copy link
Member

Thank you@Yendric.

@chalasrchalasr merged commit9230f69 intosymfony:4.4Feb 16, 2021
@chalasrchalasr removed the request for review fromdunglasFebruary 16, 2021 11:16
@Nyholm
Copy link
Member

I understand that writing a test for this is tricky (I don't know how). I was hoping for someone to come up with a genius idea =)

Thank you@Yendric for this PR and congratulations for your first contribution.

Yendric reacted with laugh emoji

This was referencedMar 4, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrchalasr approved these changes

+1 more reviewer

@Seb33300Seb33300Seb33300 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

6 participants

@Yendric@Nyholm@nicolas-grekas@chalasr@Seb33300@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp