NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[FrameworkBundle] Exclude unreadable files when executing About command#40178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:4.4frommichaljusiega:bugfix/silence-unreadable-file

Mar 16, 2021

Merged

[FrameworkBundle] Exclude unreadable files when executing About command#40178

nicolas-grekas merged 1 commit intosymfony:4.4frommichaljusiega:bugfix/silence-unreadable-file

Mar 16, 2021

Conversation

Copy link

Contributor

michaljusiega commentedFeb 13, 2021•
edited
Loading

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#39916
License	MIT
Doc PR	~

Fix as explained in:#39916.

Tests failed looks like not releated to my changes.

carsonbot added Status: Needs Review FrameworkBundle Bug labels

Feb 13, 2021

carsonbot added this to the4.4 milestone

Feb 13, 2021

ro0NL approved these changes

Feb 15, 2021

View reviewed changes

Copy link

Contributor

ro0NL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

works for me

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Feb 15, 2021

fabpot requested changes

Feb 16, 2021

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Tests/Command/AboutCommand/AboutCommandTest.phpShow resolvedHide resolved

src/Symfony/Bundle/FrameworkBundle/Tests/Command/AboutCommand/AboutCommandTest.php OutdatedShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Reviewed labels

Feb 16, 2021

michaljusiega commented

Feb 16, 2021

View reviewed changes

Copy link

ContributorAuthor

michaljusiega left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ready

javiereguiluz reviewed

Feb 19, 2021

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Tests/Command/AboutCommand/AboutCommandTest.php OutdatedShow resolvedHide resolved

fabpot requested changes

Feb 25, 2021

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Tests/Command/AboutCommand/AboutCommandTest.php OutdatedShow resolvedHide resolved

Copy link

ContributorAuthor

michaljusiega commentedMar 4, 2021

@fabpot Can We finish this PR ?

nicolas-grekas changed the title~~[FrameworkBundle] Exclude unreadable file during executing About command.~~[FrameworkBundle] Exclude unreadable file during executing About command

Mar 16, 2021

nicolas-grekas changed the title~~[FrameworkBundle] Exclude unreadable file during executing About command~~[FrameworkBundle] Exclude unreadable files during executing About command

Mar 16, 2021

[FrameworkBundle] Exclude unreadable files when executing About command

25f503a

nicolas-grekas changed the title~~[FrameworkBundle] Exclude unreadable files during executing About command~~[FrameworkBundle] Exclude unreadable files when executing About command

Mar 16, 2021