Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[PropertyInfo]  use the right context for properties defined in traits#40175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromxabbuh:issue-28732
Feb 16, 2021

Conversation

@xabbuh
Copy link
Member

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#28732,#34191
LicenseMIT
Doc PR

dunglas reacted with rocket emoji
@xabbuhxabbuh added this to the4.4 milestoneFeb 13, 2021
@carsonbotcarsonbot changed the title[PropertyInfo] use the right context for properties defined in traits[PropertyInfo]  use the right context for properties defined in traitsFeb 13, 2021
@carsonbot
Copy link

Hey!

I see that more good work is coming your way.

I think@bastnic has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@fabpot
Copy link
Member

Thank you@xabbuh.

@fabpotfabpot merged commit1b358fe intosymfony:4.4Feb 16, 2021
@xabbuhxabbuh deleted the issue-28732 branchFebruary 16, 2021 07:38
This was referencedMar 4, 2021
nicolas-grekas added a commit that referenced this pull requestApr 14, 2021
…n traits (colinodell)This PR was merged into the 4.4 branch.Discussion----------[PropertyInfo] Use the right context for methods defined in traits| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#34191| License       | MIT| Doc PR        |Pull request#40175 only partiallyfixed#34191 - it solved the problem for properties used in traits but it did not address the same issue with methods.I have therefore applied the same style of fix and confirmed it works properly with tests.Commits-------c7e9493 [PropertyInfo] Use the right context for methods defined in traits
nicolas-grekas added a commit that referenced this pull requestMay 7, 2021
…ts (soullivaneuh)This PR was squashed before being merged into the 4.4 branch.Discussion----------[PropertyInfo] fix attribute namespace with recursive traits| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       |Fix#36997 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->The targeted issue is closed because considered as solved by#40175.However, the fix is not enough and is not working with recursive trait inclusion. (see#36997 (comment)).This pull request is completing the first fix of `@xabbuh`, trying to follow the same coding style. 😉Commits-------bbadfb3 [PropertyInfo] fix attribute namespace with recursive traits
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@fabpotfabpotfabpot approved these changes

@chalasrchalasrchalasr approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@xabbuh@carsonbot@fabpot@nicolas-grekas@chalasr

[8]ページ先頭

©2009-2025 Movatter.jp