Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PropertyInfo] use the right context for properties defined in traits#40175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
xabbuh commentedFeb 13, 2021
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix#28732,#34191 |
| License | MIT |
| Doc PR |
This was referencedFeb 13, 2021
carsonbot commentedFeb 14, 2021
Hey! I see that more good work is coming your way. I think@bastnic has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
Uh oh!
There was an error while loading.Please reload this page.
chalasr approved these changesFeb 15, 2021
fabpot approved these changesFeb 16, 2021
Member
fabpot commentedFeb 16, 2021
Thank you@xabbuh. |
nicolas-grekas added a commit that referenced this pull requestApr 14, 2021
…n traits (colinodell)This PR was merged into the 4.4 branch.Discussion----------[PropertyInfo] Use the right context for methods defined in traits| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |Fix#34191| License | MIT| Doc PR |Pull request#40175 only partiallyfixed#34191 - it solved the problem for properties used in traits but it did not address the same issue with methods.I have therefore applied the same style of fix and confirmed it works properly with tests.Commits-------c7e9493 [PropertyInfo] Use the right context for methods defined in traits
nicolas-grekas added a commit that referenced this pull requestMay 7, 2021
…ts (soullivaneuh)This PR was squashed before being merged into the 4.4 branch.Discussion----------[PropertyInfo] fix attribute namespace with recursive traits| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets |Fix#36997 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->The targeted issue is closed because considered as solved by#40175.However, the fix is not enough and is not working with recursive trait inclusion. (see#36997 (comment)).This pull request is completing the first fix of `@xabbuh`, trying to follow the same coding style. 😉Commits-------bbadfb3 [PropertyInfo] fix attribute namespace with recursive traits
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.