Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Translation] Allow using dashes in locale when linting Xliff files#40172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromlocalheinz:fix/dash
Feb 16, 2021

Conversation

@localheinz
Copy link
Contributor

@localheinzlocalheinz commentedFeb 12, 2021•
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Ticketsfixes#40170
LicenseMIT
Doc PRn/a

This pull request

  • asserts that theXliffLintCommand succeeds linting an Xliff file where both the the target language and the locale in the file name use dashes as separators
  • adjusts theXliffLintCommand to allow using the same value for target language and locale in the corresponding file name

@carsonbot
Copy link

Hey!

I see that more good work is coming your way.

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

@localheinzlocalheinz marked this pull request as ready for reviewFebruary 12, 2021 19:12
@carsonbotcarsonbot added this to the4.4 milestoneFeb 12, 2021
@carsonbotcarsonbot changed the title[Translation] Allow using dashes in locale when linting Xliff files[Translator] Allow using dashes in locale when linting Xliff filesFeb 12, 2021
@localheinzlocalheinzforce-pushed thefix/dash branch 2 times, most recently from147627a to4078cdbCompareFebruary 12, 2021 19:16
Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, I am just not sure if this should be considered a bugfix or a new feature 🧐

@localheinz
Copy link
ContributorAuthor

localheinz commentedFeb 12, 2021•
edited
Loading

@OskarStark

A bug fix would be great, since the corresponding application can not yet upgrade tosymfony/translation:^5.

🤓

@OskarStark
Copy link
Contributor

I know, from my perspective it can be considered a bugfix, as you explained it is conform with the spec 👍🏻

@localheinzlocalheinz changed the title[Translator] Allow using dashes in locale when linting Xliff files[Translation] Allow using dashes in locale when linting Xliff filesFeb 12, 2021
@localheinzlocalheinz changed the title[Translation] Allow using dashes in locale when linting Xliff files[Translator] Allow using dashes in locale when linting Xliff filesFeb 14, 2021
@localheinzlocalheinz changed the title[Translator] Allow using dashes in locale when linting Xliff files[Translation] Allow using dashes in locale when linting Xliff filesFeb 15, 2021
@fabpot
Copy link
Member

Thank you@localheinz.

@fabpotfabpot merged commitaa21944 intosymfony:4.4Feb 16, 2021
@localheinzlocalheinz deleted the fix/dash branchFebruary 16, 2021 07:18
@localheinz
Copy link
ContributorAuthor

Thank you,@derrabus,@fabpot,@nicolas-grekas, and@OskarStark!

OskarStark reacted with heart emoji

@sschueller
Copy link

Will this change validatede-x-app123 orde-x-app123-a as valid? According to xliff 1.2 (urn:oasis:names:tc:xliff:document:1.2) this should be validated withxsd:language which is[a-zA-Z]{1,8}(-[a-zA-Z0-9]{1,8})*

@OskarStark
Copy link
Contributor

Open for a PR including a testcase so we can talk about code and an example?

xabbuh reacted with thumbs up emoji

This was referencedMar 4, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@derrabusderrabusderrabus approved these changes

@nicolas-grekasnicolas-grekasAwaiting requested review from nicolas-grekas

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

7 participants

@localheinz@carsonbot@OskarStark@fabpot@sschueller@nicolas-grekas@derrabus
[8]ページ先頭
©2009-2025 Movatter.jp