Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Finder] mark the LazyIterator class as internal#40163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromxabbuh:lazy-iterator-internal
Feb 12, 2021

Conversation

@xabbuh
Copy link
Member

@xabbuhxabbuh commentedFeb 12, 2021•
edited
Loading

QA
Branch?4.4
Bug fix?no
New feature?no
Deprecations?no
Tickets#40040 (comment)
LicenseMIT
Doc PR

derrabus reacted with thumbs up emoji
@jderusse
Copy link
Member

Thanks for taking care of this. Could you please also take#40040 (comment) into account?

@ro0NL
Copy link
Contributor

ro0NL commentedFeb 12, 2021•
edited
Loading

why not keep support forFinder::append(new LazyIterator($callable))?

appendFromCallable for 5.x maybe, then it can become internal IMHO

@stof
Copy link
Member

@ro0NL this can was merged 4 hours ago. so there is no support to keep.Finder::append(new LazyIterator($callable)) is not supported in any released version of Symfony, becauseLazyIterator does not exist there.

@ro0NL
Copy link
Contributor

ro0NL commentedFeb 12, 2021•
edited
Loading

right, i meant introducing the feature in 4.x as a bonus side effect yes

unless we have other plans for 5.x, or we conclude it's not useful for users at all

@fabpot
Copy link
Member

Thank you@xabbuh.

@fabpotfabpot merged commit4626100 intosymfony:4.4Feb 12, 2021
@xabbuhxabbuh deleted the lazy-iterator-internal branchFebruary 12, 2021 15:35
@xabbuh
Copy link
MemberAuthor

@jderusse I didn't read your comment before the PR was merged. Feel free to open a PR with your suggestion.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

6 participants

@xabbuh@jderusse@ro0NL@stof@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp