Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle][Translator] scan directories for translations sequentially#40116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedFeb 6, 2021
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix#40014 |
| License | MIT |
| Doc PR |
05bce3a to29c971cCompare| ->sortByName() | ||
| ; | ||
| foreach ($finderas$file) { | ||
| $fileNameParts =explode('.',basename($file)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is there a reason for using basename over $file->getBasename()?
| ; | ||
| foreach ($finderas$file) { | ||
| $fileNameParts =explode('.',basename($file)); | ||
| $locale =$fileNameParts[\count($fileNameParts) -2]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggestion : Wouldn't $info->getBasename($info->getExtension())) give us the locale? Assuming the filer is only matching patterns such as 'ar.json'? I would remove the need for the explode and fileparts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That code was here before. I suggest not to change it as part of this bugfix.
xabbuh commentedFeb 7, 2021
@jderusse test added |
nicolas-grekas commentedFeb 7, 2021
Thank you@xabbuh. |