Hey!

You, my friend, deserve a BIG HUG for making this PR.

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

Dunno why@carsonbot closed this one.

I think it was closed because I didn't read well the first comment
To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

I'm moving this to "ready for review"

hello, isnt this "similar" tohttps://symfony.com/doc/current/reference/configuration/framework.html#ide?

hello, isn't this "similar" tohttps://symfony.com/doc/current/reference/configuration/framework.html#ide?

Yes, but not all IDEs support that feature, I think it would be worth it.

👍 on my side.

Oh does the icon work in dark mode? Can you please update your screenshot?

These are the updated screenshots:

PS: What about coding standard issues found by fabbot? Should I fix them?

I am with@noniagriconomie. I am also a bit confused =)

The way I see it, on the error page, you see the relative path to each line in the stack trace. If you click at any of them it will open in PHPStorm... if you dont have it configured that way, you will get the file opened in the broswer and there you will see the absolute path.

I think that allowing a copy/paste of the path of the file is interesting.
In order to account for Docker/etc, we could allow passing a 3rd$format argument toFileLinkFormatter::format(), that would be used instead of$fmt[0] when possible, on the last line here:

Then we would patch HtmlRenderer::getFileLink to also handle and forward the same optional argument.

@lmillucci works for you? Can you please update the PR to account for all latest comments?

I think that allowing a copy/paste of the path of the file is interesting.
In order to account for Docker/etc, we could allow passing a 3rd$format argument toFileLinkFormatter::format(), that would be used instead of$fmt[0] when possible, on the last line here:

symfony/src/Symfony/Component/HttpKernel/Debug/FileLinkFormatter.php

Lines 49 to 59 in4d91b8f

	publicfunctionformat(string$file,int$line)
	{
	if ($fmt =$this->getFileLinkFormat()) {
	for ($i =1;isset($fmt[$i]); ++$i) {
	if (0 ===strpos($file,$k =$fmt[$i++])) {
	$file =substr_replace($file,$fmt[$i],0,\strlen($k));
	break;
	}
	}
	returnstrtr($fmt[0], ['%f' =>$file,'%l' =>$line]);

Then we would patch HtmlRenderer::getFileLink to also handle and forward the same optional argument.

@lmillucci works for you? Can you please update the PR to account for all latest comments?

I'm not sure about the behavior of the$format argument ofFileLinkFormatter::format(). I can add it to the function to override the default format but how should I use it in this situation?

I would display the copy button only on hover to avoid having too many icons on the page.

I've updated the branch to display the icon only on hover. I'm still not sure about what should I do withFileLinkFormatter

This is an example:

@lmillucci Can you rebase on the current 5.4 branch to resolve the conflicts? Ping me when it's done so that I can merge this PR. Thank you.

@fabpot rebased 👍

Thank you@lmillucci.