Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer] Prevent access to private properties without getters#40004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

julienfalque
Copy link
Contributor

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

When upgradingsymfony/serializer fromv5.2.1 tov5.2.2, the serializer starts throwing exceptions because it cannot access some private properties that don't have a getter. This looks related to#38900.

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

too bad we missed this!

@nicolas-grekas
Copy link
Member

Thank you@julienfalque.

@nicolas-grekasnicolas-grekas merged commit8533ea2 intosymfony:4.4Jan 27, 2021
@julienfalquejulienfalque deleted the serializer-private-properties-without-getters branchJanuary 27, 2021 19:02
@julienfalque
Copy link
ContributorAuthor

Thank you@nicolas-grekas :)

@andrzej-tracz
Copy link

@nicolas-grekas
This change has been merged into branch 4.4 but for some reason the most recent release - v4.4.19 doesn't contain that:

https://github.com/symfony/symfony/blob/v4.4.19/src/Symfony/Component/Serializer/Normalizer/ObjectNormalizer.php#L110

this bug still appears on v4.4.19 and PHP version < 7.4.

@nicolas-grekas
Copy link
Member

It's for v4.4.20 apparently:https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Serializer/Normalizer/ObjectNormalizer.php#L110

andrzej-tracz and althaus reacted with thumbs up emoji

@fabpotfabpot mentioned this pull requestMar 4, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

4 participants
@julienfalque@nicolas-grekas@andrzej-tracz@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp