Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Security] Refresh original user in SwitchUserListener#39992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@AndrolGenhald
Copy link
Contributor

Fixes#39991

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#39991
LicenseMIT
Doc PRNA

Fix SwitchUserListener to update original token with refreshed user. This prevents a non-refreshed user from causing problems elsewhere, such as in Voters.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@nicolas-grekasnicolas-grekas changed the titleRefresh original user in SwitchUserListener.[Security/Http] Refresh original user in SwitchUserListenerJan 27, 2021
@carsonbotcarsonbot changed the title[Security/Http] Refresh original user in SwitchUserListener[Security] [Security/Http] Refresh original user in SwitchUserListenerMar 8, 2021
@derrabusderrabus changed the title[Security] [Security/Http] Refresh original user in SwitchUserListener[Security] Refresh original user in SwitchUserListenerMar 8, 2021
@chalasr
Copy link
Member

@AndrolGenhald Could you address the remaining review comment so that we can move this PR forward?

@AndrolGenhaldAndrolGenhaldforce-pushed thebugfix/switch_user_listener_refresh_user branch from2a55611 to008a448CompareMarch 12, 2021 00:34
@AndrolGenhaldAndrolGenhaldforce-pushed thebugfix/switch_user_listener_refresh_user branch from008a448 to4245345CompareMarch 12, 2021 01:21
@fabpot
Copy link
Member

Thank you@AndrolGenhald.

AndrolGenhald reacted with hooray emoji

@fabpotfabpot merged commit2bfc641 intosymfony:4.4Mar 12, 2021
This was referencedMar 29, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@derrabusderrabusderrabus approved these changes

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

@wouterjwouterjAwaiting requested review from wouterjwouterj is a code owner

+1 more reviewer

@maxheliasmaxheliasmaxhelias left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

7 participants

@AndrolGenhald@carsonbot@chalasr@fabpot@OskarStark@derrabus@maxhelias
[8]ページ先頭
©2009-2025 Movatter.jp