Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DoctrineBridge] Make subscriber and listeners prioritizable#39978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
21eb8d5 to5c53f99CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
...ridge/Doctrine/DependencyInjection/CompilerPass/RegisterEventListenersAndSubscribersPass.phpShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
nicolas-grekas approved these changesJan 27, 2021
610a999 toa74f232CompareUh oh!
There was an error while loading.Please reload this page.
This was referencedJan 31, 2021
nicolas-grekas added a commit that referenced this pull requestFeb 4, 2021
This PR was merged into the 4.4 branch.Discussion----------[Doctrine] Restore priority for EventSubscribers| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |fix#40031| License | MIT| Doc PR | -Since#39990, lazy subscribers are called AFTER listeners (which is the opposite of previous implementation).This PR restore the previous behavior.Note: ordered subscribers is implemented in#39978 but is considered as a new feature.Commits-------94eac1b Restore priority for eventSubscribers
fabpot approved these changesFeb 5, 2021
Member
fabpot commentedFeb 5, 2021
@jderusse Can you rebase? |
a74f232 to14a613bCompare Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle Doctrine's eventSubscriber and eventListener priority (listener exposed by the eventSubscriber will have the same priority than the eventListener)