NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Mailer][Mime] Fix case-sensitive handling of header names#39954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:5.2frompiku235:ticket_39953

Feb 2, 2021

Merged

[Mailer][Mime] Fix case-sensitive handling of header names#39954

fabpot merged 1 commit intosymfony:5.2frompiku235:ticket_39953

Feb 2, 2021

Conversation

Copy link

Contributor

piku235 commentedJan 23, 2021

Q	A
Branch?	5.2
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#39953
License	MIT
Doc PR	-

Fixes case-sensitive handling of header names in "Mime" and "Mailer" component, more in theticket.

carsonbot added Status: Needs Review Mime Mailer Bug labels

Jan 23, 2021

carsonbot changed the title~~[Mime][Mailer] Fix case-sensitive handling of header names~~[Mime] [Mailer] Fix case-sensitive handling of header names

Jan 23, 2021

carsonbot added this to the5.2 milestone

Jan 23, 2021

carsonbot changed the title~~[Mime] [Mailer] Fix case-sensitive handling of header names~~[Mailer][Mime] Fix case-sensitive handling of header names

Jan 23, 2021

Copy link

carsonbot commentedJan 24, 2021

Hey!

Nice work here, I this makes me happy.

I think @scuben has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

fabpot approved these changes

Feb 1, 2021

View reviewed changes

Copy link

Member

fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is 4.4 affected? Is yes, can you change the target to 4.4 instead? Thank you.

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Feb 1, 2021

Copy link

ContributorAuthor

piku235 commentedFeb 1, 2021

The commitsf1bcece and70f703d depend on the v5.2, they relate to#36736.

The commit0a91e7f fixesHeaders::isUnique() which exists since the very beginning of thesymfony/mime component (introduced in v4.3), so it exists also for v4.4. I guess there's no need to do it for v4.3 as it's not maintained anymore.
I think we can create a separate PR targeting v4.4 and cherry-pick this commit (with small update), what do you think?

Copy link

Member

fabpot commentedFeb 1, 2021

Let's create a PR for 4.4.

piku235 mentioned this pull request

Feb 1, 2021

[Mime] Fix case-sensitive handling of header names#40062

Merged

Copy link

ContributorAuthor

piku235 commentedFeb 1, 2021

Ok, done#40062.

fabpot approved these changes

Feb 2, 2021

View reviewed changes

fabpot added a commit that referenced this pull request

Feb 2, 2021

bug#40062[Mime] Fix case-sensitive handling of header names (piku235)

ccdcac2

This PR was merged into the 4.4 branch.Discussion----------[Mime] Fix case-sensitive handling of header names| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#39953| License       | MIT| Doc PR        | -Fixes case-sensitive handling of header names in "Mailer" component, more in the [ticket](#39953) and the [root PR](#39954).Commits-------b2d7454 [Mime] Fix case-sensitive handling in Headers::isUniqueHeader()