Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] [SpotHit] Add the bridge#39948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
OskarStark merged 1 commit intosymfony:5.xfromJamesHemery:spothit-notifier
Feb 3, 2021

Conversation

@JamesHemery
Copy link
Contributor

@JamesHemeryJamesHemery commentedJan 23, 2021•
edited
Loading

QA
Branch?5.x
Bug fix?no
New feature?yes
Deprecations?no
LicenseMIT
Doc PRsymfony/symfony-docs#14869
Recipe PRsymfony/recipes#881

@OskarStark Bridge added :)

OskarStark reacted with rocket emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@JamesHemeryJamesHemery changed the title[Notifier] Spot-Hit bridge[Notifier][SpotHit] Add the bridgeJan 23, 2021
@nicolas-grekasnicolas-grekas added this to the5.x milestoneJan 23, 2021
Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just some minor last comments

@OskarStark
Copy link
Contributor

@JamesHemery open to finish this PR? 😃

JamesHemery reacted with thumbs up emoji

@OskarStark
Copy link
Contributor

One last comment, lets name name packagesymfony/spothit-notifer please, same for docs and recipe, afterwards good to go 👍

JamesHemery reacted with thumbs up emoji

@carsonbotcarsonbot changed the title[Notifier][SpotHit] Add the bridge[Notifier] [SpotHit] Add the bridgeFeb 2, 2021
@OskarStark
Copy link
Contributor

Thanks James for working on this feature, this is much appreciated.

JamesHemery reacted with thumbs up emoji

@OskarStarkOskarStark merged commit3eb8a42 intosymfony:5.xFeb 3, 2021
@JamesHemeryJamesHemery deleted the spothit-notifier branchFebruary 4, 2021 10:45
@fabpot
Copy link
Member

FYI, I've fixed the package name in#40186

JamesHemery and OskarStark reacted with thumbs up emoji

@fabpotfabpot mentioned this pull requestApr 18, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

@derrabusderrabusderrabus approved these changes

@chalasrchalasrAwaiting requested review from chalasr

@xabbuhxabbuhAwaiting requested review from xabbuh

@fabpotfabpotAwaiting requested review from fabpot

@nicolas-grekasnicolas-grekasAwaiting requested review from nicolas-grekas

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

6 participants

@JamesHemery@carsonbot@OskarStark@fabpot@derrabus@nicolas-grekas
[8]ページ先頭
©2009-2025 Movatter.jp