Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PropertyInfo] Fix breaking change with has*(arguments...) methods#39896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
xabbuh merged 1 commit intosymfony:5.1fromYaFou:has-method-property-info
Jan 22, 2021

Conversation

@YaFou
Copy link
Contributor

QA
Branch?5.1
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#39885
LicenseMIT
Doc PRsymfony/symfony-docs#...

Until 5.0:

class Dummy{private$elements;publicfunctionhasElement($element):bool    {// ...    }}$extractor =newReflectionExtractor();$extractor->isReadable('Dummy','element');// false

After 5.0:

class Dummy{private$elements;publicfunctionhasElement($element):bool    {// ...    }}$extractor =newReflectionExtractor();$extractor->isReadable('Dummy','element');// true => BREAKING CHANGE

@YaFouYaFouforce-pushed thehas-method-property-info branch from25d1299 to37cc16eCompareJanuary 20, 2021 21:16
@pamil
Copy link
Contributor

It solves the issue for me (#39885), thanks! Travis CI build for PHP 8.0 is failing due to some networking issues, could it be restarted? Same for AppVeyor, it seems like an unrelated failure.

YaFou reacted with hooray emoji

@xabbuh
Copy link
Member

@pamil CI restarted and green

pamil reacted with hooray emoji

@xabbuh
Copy link
Member

Thank you@YaFou.

@xabbuhxabbuh merged commitde8ddfd intosymfony:5.1Jan 22, 2021
@YaFouYaFou deleted the has-method-property-info branchJanuary 22, 2021 17:45
This was referencedJan 27, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@dunglasdunglasdunglas approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

6 participants

@YaFou@pamil@xabbuh@dunglas@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp