Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mime] Escape commas in address names#39866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromYaFou:comma-in-address-name
Mar 12, 2021

Conversation

@YaFou
Copy link
Contributor

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#39416
LicenseMIT
Doc PR--

Before:

$address =newAddress('fabien@symfony.com','Fabien, Potencier');$address->toString();// Fabien, Potencier <fabien@symfony.com> -> Interpreted like two emails

After:

$address =newAddress('fabien@symfony.com','Fabien, Potencier');$address->toString();// "Fabien, Potencier" <fabien@symfony.com>

@carsonbot
Copy link

Hey!

I didn't know that was capable of this emotion. I really really like reviewing this PR. Well done.

I think@Cartman34 has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@YaFouYaFouforce-pushed thecomma-in-address-name branch fromc89ff21 to39e9158CompareJanuary 19, 2021 18:34
@fabpot
Copy link
Member

Thank you@YaFou.

@fabpotfabpot merged commit93467c5 intosymfony:4.4Mar 12, 2021
This was referencedMar 29, 2021
@YaFouYaFou deleted the comma-in-address-name branchMay 23, 2021 08:35
vinibrsl added a commit to plausible/bamboo_postmark that referenced this pull requestNov 28, 2022
This PR encodes names with quotes when building e-mails, e.g. "John Doe"<johndoe@provider.test>. This adds support for special names with commasand even quotes.Related:symfony/symfony#39866,plausible/analytics#1885
vinibrsl added a commit to plausible/bamboo_postmark that referenced this pull requestNov 28, 2022
This PR encodes names with quotes when building e-mails, e.g. "John Doe"<johndoe@provider.test>. This adds support for special names with commasand even quotes.Related:symfony/symfony#39866,plausible/analytics#1885
vinibrsl added a commit to plausible/bamboo_postmark that referenced this pull requestNov 28, 2022
This PR encodes names with quotes when building e-mails, e.g. "John Doe"<johndoe@provider.test>. This adds support for special names with commasand even quotes.Related:symfony/symfony#39866,plausible/analytics#1885
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

+4 more reviewers

@Cartman34Cartman34Cartman34 left review comments

@sstoksstoksstok left review comments

@fbourigaultfbourigaultfbourigault left review comments

@maxheliasmaxheliasmaxhelias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

7 participants

@YaFou@carsonbot@fabpot@Cartman34@sstok@fbourigault@maxhelias
[8]ページ先頭
©2009-2025 Movatter.jp