Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DomCrawler] improve failure messages of the CrawlerSelectorTextContains constraint#39856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromxabbuh:issue-33551
Aug 26, 2021

Conversation

@xabbuh
Copy link
Member

@xabbuhxabbuh commentedJan 16, 2021•
edited
Loading

QA
Branch?5.x
Bug fix?no
New feature?no
Deprecations?no
TicketsFix#33551,#37757
LicenseMIT
Doc PR

kalibora reacted with thumbs up emoji
@nicolas-grekas
Copy link
Member

This will need a PR on lower branches, to relax the assertions when fwb is used with domcrawler ^5.3

@xabbuh
Copy link
MemberAuthor

That's true, the alternative would be to merge this in a lower branch. But since this is not a bugfix I think we should not do that.

@fabpot
Copy link
Member

If that's easier for us, let's do that change in 4.4?

@xabbuhxabbuh changed the base branch from5.x to4.4February 5, 2021 09:54
@xabbuhxabbuhforce-pushed theissue-33551 branch 3 times, most recently from8492fd1 to6cdd8d6CompareFebruary 8, 2021 11:47
@xabbuh
Copy link
MemberAuthor

rebased on 4.4

@xabbuhxabbuh modified the milestones:5.x,4.4Feb 26, 2021
@fabpot
Copy link
Member

Thank you@xabbuh.

@fabpotfabpot merged commit3ff5db6 intosymfony:4.4Aug 26, 2021
This was referencedAug 30, 2021
@xabbuhxabbuh deleted the issue-33551 branchOctober 5, 2021 11:57
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

Could assertSelectorTextContains return current value in WebTestCase?

4 participants

@xabbuh@nicolas-grekas@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp