Adds a format to the Twig linter command to print Github Actions annotations when an error occurred (documentation). There is a new format:github and the command will detect automatically the format to use in comparison with the environment.

See a workflow example:https://github.com/YaFou/symfony-39826/actions/runs/485093369

TODO:

Changelog
Test with a real project

Copy link

carsonbot commentedJan 14, 2021

Hey!

I like what you have done here. Keep up the good work.

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

YaFou marked this pull request as ready for review

January 14, 2021 09:30

carsonbot added Status: Needs Review TwigBridge Feature labels

Jan 14, 2021

YaFou force-pushed thegithub-twig-lint-command branch fromdc33317 toc46d100Compare

January 14, 2021 09:33

stof reviewed

Jan 14, 2021

View reviewed changes

src/Symfony/Bridge/Twig/Command/LintCommand.php OutdatedShow resolvedHide resolved

stof requested changes

Jan 14, 2021

View reviewed changes

src/Symfony/Bridge/Twig/Command/LintCommand.php OutdatedShow resolvedHide resolved

src/Symfony/Bridge/Twig/Tests/Command/LintCommandTest.php OutdatedShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Jan 14, 2021

YaFou force-pushed thegithub-twig-lint-command branch fromc46d100 toe705232Compare

January 14, 2021 09:49

YaFou requested a review fromstof

January 14, 2021 10:23

carsonbot added Status: Needs Review and removed Status: Needs Work labels

Jan 14, 2021

nicolas-grekas added this to the5.x milestone

Jan 14, 2021

YaFou mentioned this pull request

Jan 14, 2021

Add Github annotations support to all linters#39122

Closed

2 tasks

OskarStark reviewed

Jan 14, 2021

View reviewed changes

src/Symfony/Bridge/Twig/CHANGELOG.md OutdatedShow resolvedHide resolved

src/Symfony/Bridge/Twig/Command/LintCommand.php OutdatedShow resolvedHide resolved

YaFou force-pushed thegithub-twig-lint-command branch frome705232 tob51062aCompare

January 14, 2021 20:57

OskarStark reviewed

Jan 30, 2021

View reviewed changes

src/Symfony/Bridge/Twig/Command/LintCommand.phpShow resolvedHide resolved

src/Symfony/Bridge/Twig/Command/LintCommand.php OutdatedShow resolvedHide resolved

Copy link

Member

chalasr commentedMar 24, 2021

@YaFou Could you address the remaining comments and rebase your branch against the latest 5.x? Or do you want someone else to take over?

Copy link

ContributorAuthor

YaFou commentedMar 24, 2021

@YaFou Could you address the remaining comments and rebase your branch against the latest 5.x? Or do you want someone else to take over?

I will do it this evening.

YaFou force-pushed thegithub-twig-lint-command branch 6 times, most recently from78f4dff to82e7148Compare

May 24, 2021 15:55

Copy link

ContributorAuthor

YaFou commentedMay 24, 2021

The tests failed becauseGithubActionReporter was not found. However, I don't understand because I bumped thesymfony/console version incomposer.json to5.3 (whereGithubActionReporter was implemented).