When\Symfony\Component\Mailer\Mailer send an email via the Bus (async) it dispatches anMessageEvent, then the consumer call the\Symfony\Component\Mailer\Transport\AbstractTransport::send method which also dispatches anMessageEvent.

This event is listened by\Symfony\Bridge\Twig\Mime\BodyRenderer::render which rendered twice an email.

I'm not sure why the event is send twice, and if we could safely remove one of them (or maybe deprecating theMessageEvent, in favor ofSendMessageEvent +AsyncMessageEvent)

This PR store a flag in the Message to avoid rendering it twice.

carsonbot added Status: Needs Review Feature labels

Jan 5, 2021

jderusse force-pushed thetwig-render-email-once branch from3917970 tob0f4188Compare

January 5, 2021 22:30

Copy link

Member

Nyholm commentedJan 6, 2021

@carsonbot do you know who could review this?

Copy link

Member

Nyholm commentedJan 6, 2021

@carsonbot please find me a reviewer

Copy link

carsonbot commentedJan 6, 2021

@pupaxxo could maybe review this PR?

Nyholm approved these changes

Jan 6, 2021

View reviewed changes

Copy link

Member

Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you

src/Symfony/Bridge/Twig/Mime/BodyRenderer.phpShow resolvedHide resolved

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jan 6, 2021

nicolas-grekas added this to the5.x milestone

Jan 7, 2021

derrabus added the TwigBridge label

Jan 8, 2021

carsonbot changed the title~~Render email once~~[TwigBridge] Render email once

Jan 8, 2021

Copy link

Contributor

ajgarlag commentedFeb 5, 2021

I think that this PR is not a feature, but a bug fix and that it should be merged into the 4.4 branch.

My problem is that when my app sends a templated email to the async transport, it is rerenderd in an HTTP context and stored with the URLs pointing to the correct hostname, but when the message is consumed from the consolemessage:consume command it is rendered again in a CLI context, and the URL finally points tolocalhost.

I know that it can be fixed by setting therouter.request_context.host parameter, but it is not so easy in a multitenant environment, and it's annoying to see that the email body in the profiler differs from the email body really sent to my address.

Copy link

MemberAuthor

jderusse commentedFeb 5, 2021

I know that it can be fixed by setting therouter.request_context.host parameter, but it is not so easy in a multitenant environment, and it's annoying to see that the email body in the profiler differs from the email body really sent to my address.

This issue is addressed by another of my PR 😛#39688