Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[TwigBridge] Remove full head content in HTML to text converter#39717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4frompupaxxo:patch-2
Jan 5, 2021

Conversation

@pupaxxo
Copy link
Contributor

When extracting text from HTML part all the content between opening and closing tag should be removed

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets
LicenseMIT
Doc PRsymfony/symfony-docs#...

Without thes flag the preg_replace match only head (or style) tags on a single line

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbotcarsonbot changed the titleRemove full head content in HTML to text converter[TwigBridge] Remove full head content in HTML to text converterJan 4, 2021
@derrabus
Copy link
Member

Can you please add a test case for your change?

When extracting text from HTML part all the content between opening and closing tag should be removed
@pupaxxo
Copy link
ContributorAuthor

yep, added 👍

The test is failing on 4.4

@fabpot
Copy link
Member

Thank you@pupaxxo.

@fabpotfabpot merged commitef11c2c intosymfony:4.4Jan 5, 2021
This was referencedJan 27, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@pupaxxo@carsonbot@derrabus@fabpot
[8]ページ先頭
©2009-2025 Movatter.jp