Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle][Messenger] Added RouterContextMiddleware#39688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
0a55b33 tob3beab6CompareUh oh!
There was an error while loading.Please reload this page.
b3beab6 to9a32c89Comparesrc/Symfony/Bundle/FrameworkBundle/Messenger/RouterContextMiddleware.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
9a32c89 tob13bb37Compareb13bb37 to78b8d3fCompare78b8d3f to1377b21CompareMember
nicolas-grekas commentedFeb 6, 2021
on deps=low |
c5ef324 to821fa53Comparenicolas-grekas approved these changesFeb 7, 2021
821fa53 to8fe8b96Comparederrabus approved these changesFeb 9, 2021
Member
nicolas-grekas commentedFeb 11, 2021
Thank you@jderusse. |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When handling a message in async, we, sometimes need the Router Context to generate absolute URL. ie:
People can use the configuration
router.default_urito workaround and fix the issue, but this does not work when the web application servers several domains.This PR provide a new middleware that store the current router context in a stamp, and restore the context when processing the message.