I need a little help with that test:

During the construction ofIdentificationHeader the email validator is called. After upgrading the library to v3, all of the special characters used here are rejected by the validator:+&%$. I am not familiar with the spec, but my gut feeling is that neither of those characters should be part of a domain name.

@fabpot you are the author of that test: Do you recall what is tested here and have an idea how we can proceed with the changed behavior ofegulias/email-validator?

I need a little help with that test:

symfony/src/Symfony/Component/Mime/Tests/Header/IdentificationHeaderTest.php

Lines 109 to 118 in04c67e6

	publicfunctiontestIdRightCanBeDotAtom()
	{
	/* -- RFC 2822, 3.6.4.
	id-right = dot-atom-text / no-fold-literal / obs-id-right
	*/
	$header =newIdentificationHeader('References','a@b.c+&%$.d');
	$this->assertEquals('a@b.c+&%$.d',$header->getId());
	$this->assertEquals('<a@b.c+&%$.d>',$header->getBodyAsString());
	}

During the construction ofIdentificationHeader the email validator is called. After upgrading the library to v3, all of the special characters used here are rejected by the validator:+&%$. I am not familiar with the spec, but my gut feeling is that neither of those characters should be part of a domain name.

@fabpot you are the author of that test: Do you recall what is tested here and have an idea how we can proceed with the changed behavior ofegulias/email-validator?

But these characters are valid (seehttps://tools.ietf.org/html/rfc2822#section-3.2.4). If looks like a wrong change in email validator.

Indeed, when validating strictly according to the RFC, these characters should be allowed if I read the RFC correctly. Friendly ping to@egulias.

Hello there,
thanks for the ping, happy to help.
As you can read in thebreacking changes for v3 is that domain will be enforced towards RFC1035 ("internet domains" RFC). The reasons for this change are that email RFCs are very broad in the requirement for the domain part (chich caused a series of "user" complications" and "suggest" to follow RFC1035 and the fact that in Real Life® SMTP follow RFC1035.

@egulias Thanks for the comment. The main "issue" here is that we are validating a message id/reference/reply to and for those, I'm not sure we should use RFC 1035. At least, that would be a BC break (which we can assume for good reasons). Is there a way to keep validating according to the original spec?

Hi@fabpot ,
what would solve the issue would be adding support for it, as suggested inegulias/EmailValidator#193 (comment) ; RFC2822 is deprecated in favour of RFC5322 with the described behaviour in the issue.

To solve this two options come to my mind:

a) is for Symfony to add a custom validator for it implementing the interface.

b) is to make it the next feature to be added. I can work on my own here but it will take time; some help would be very much appreciated to speed it up.

Happy to hear more possibilites.

Hi@fabpot@derrabus ,
To better address the validations of ID & mailbox (https://tools.ietf.org/html/rfc2822#section-3.4), can you point me to how this is used and were? I'm aware of Symfony's Email component and the validator, but it would be of great help to know where to look.
While mailbox has some patterns to distinguish from an email address, id has some challenges.
I'm pondering adding an specific method for validating them or having the capability of distinguishing from the pattern.
Which would better help you?

Ok. So did a research on how the validator is being used in Symfony & Swiftmailer.

My conclusion is as follows:
Symfony (and Swiftmailer for that matter) are using the EmailValidator for validating a Header field "message-id" (section 3.6.4) which has a different syntaxisfor the right side after the @ sign than "addr-spec" (section 3.4.1) which is the commonly known as "email address".

This was possible in version <3 of the EmailValidator because of the interpretation done of the RFC.
Version 3 follows the suggestions of the RFC and user land feedback, by following RFC 1035 (see below for details), breaking that use case.

The solution for this, then, is to create a new validation for "message-id" and then addaptAddress to it.
The change would be inAddress#L54:

if (!self::$validator->isValid($this->address,newMessageIDValidation())) {

@fabpot@xabbuh & others, please let me know if this would work for you.

Details

The exception bubbles fromAddress in the Mime component, used from theIdentificationHeader when building from message IDs.

Now, here's the thing.message-id has a different syntaxis forid-right (not a "domain" as will see) thanaddr-spec has for it. In fact, despite previous use-case seeming to validate, it was actually allowing for non-compliantid-right elemtns, like[ orCFWS.

id-right

dot-atom-text / no-fold-literal / obs-id-right

To note thatobs-id-right in4.5.4 is defined asdomain

domain syntaxis

domain = dot-atom / domain-literal / obs-domain

domain-literal = [CFWS] "[" *([FWS] dcontent) [FWS] "]" [CFWS]

dcontent = dtext / quoted-pair

dtext = NO-WS-CTL / ; Non white space controls
%d33-90 / ; The rest of the US-ASCII
%d94-126 ; characters not including "[",
; "]", or ""

And at the ends, specifies:

The domain portion identifies the point to which the mail is
delivered. In the dot-atom form, this is interpreted as an Internet
domain name (either a host name or a mail exchanger name) as
described in [STD3, STD13, STD14]. In the domain-literal form, the
domain is interpreted as the literal Internet address of the
particular host. In both cases, how addressing is used and how
messages are transported to a particular host is covered in the mail
transport document [RFC2821]. These mechanisms are outside of the
scope of this document.

STD13 is RFC1035

Hi there!
I've done some progress and I have a working solution. I should be able to release v3.1 in a couple of weeks.
It will require the change in the line mentioned in#39685 (comment)
The change would be inAddress#L54:

if (!self::$validator->isValid($this->address,newMessageIDValidation())) {

@egulias That's great news, thank you. Give me a ping as soon as we can test the new validator. I'll update this PR then.

PR ready@derrabusegulias/EmailValidator#290 , will give it a week and merge next one.

@egulias This PR now runs against your feature branch and the tests are green now. Apparently, your changes work for us. 🎉

@derrabusreleasedone! You can continue now, let me know when it is done!
Thanks for your help!

Thank you, the PR is ready now. 🚀

Thank you@egulias!

Thank you@derrabus.

Thanks! I've merged the changes up to 5.x and resolved all the composer.json conflicts.

Thank you@fabpot,@derrabus and@egulias ;)