Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Mailer] Add Support for email-validator v3#39657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
ben29 wants to merge1 commit intosymfony:5.xfromben29:patch-1
Closed

[Mailer] Add Support for email-validator v3#39657

ben29 wants to merge1 commit intosymfony:5.xfromben29:patch-1

Conversation

@ben29
Copy link
Contributor

@ben29ben29 commentedDec 29, 2020
edited
Loading

QA
Branch?5.x
Bug fix?yes
New feature?no
Deprecations?yes
TicketsFix #...
LicenseMIT
Doc PRsymfony/symfony-docs#...

@michaljusiega
Copy link
Contributor

Ticket:#39656

@carsonbotcarsonbot changed the titleAdd Support for email-validator v3[Mailer] Add Support for email-validator v3Dec 29, 2020
@OskarStark
Copy link
Contributor

Can please check if other Components use this too and bump them also? Thanks

"require": {
"php":">=7.2.5",
"egulias/email-validator":"^2.1.10",
"egulias/email-validator":"^2.1.10|^3.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There are more places where this package needs to be bumped. Furthermore, we should try to patch the 4.4 branch instead.

OskarStark reacted with thumbs up emoji
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

yes, on all the mailer components

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I would prefer 4.4, too

VincentLanglet reacted with thumbs up emoji
@derrabus
Copy link
Member

Closing in favor of#39685.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@derrabusderrabusderrabus requested changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@ben29@michaljusiega@OskarStark@derrabus@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp