Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[VarDumper] fixed displaying "mixed" as "?mixed"#39629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedDec 26, 2020
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
derrabus left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good catch! I've build a test case locally to test your fix and found that the caster is also broken for nullable union types. I will submit a followup PR.
derrabus commentedDec 26, 2020
Good catch, thanks Nicolas. |
derrabus commentedDec 26, 2020
Followup:#39631 |
…rrabus)This PR was merged into the 4.4 branch.Discussion----------[VarDumper] Fix display of nullable union return types| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |#39629 (review)| License | MIT| Doc PR | N/ACommits-------efeb2dc [VarDumper] Fix display of nullable union return types.