Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] addSentMessageEvent andFailedMessageEvent#39601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@ismail1432
Copy link
Contributor

@ismail1432ismail1432 commentedDec 21, 2020•
edited by derrabus
Loading

QA
Branch?5.4
Bug fix?no
New feature?yes
LicenseMIT
Doc PR

Dispatch a new eventSentMessageEventwhich is dispatched once the notification is sent. TheSymfony\Component\Notifier\Transport\AbstractTransport return an instance ofSentMessage that contains the original message + an id thatcan be returned by the API it can be helpful to pass this object to the event.

Dispatch a new eventFailedMessageEventwhich is dispatched if sending the notification fails it can be helpful for a retry strategy

@carsonbotcarsonbot changed the titleadd SentMessageEvent[Notifier] add SentMessageEventDec 21, 2020
@ismail1432ismail1432force-pushed thenotifier-add-sent-message-event branch 2 times, most recently from97876db toc28ea75CompareDecember 21, 2020 23:13
@ismail1432ismail1432force-pushed thenotifier-add-sent-message-event branch fromb8bb755 tod6c7aa2CompareDecember 23, 2020 08:02
@nicolas-grekasnicolas-grekas added this to the5.x milestoneDec 23, 2020
@ismail1432ismail1432force-pushed thenotifier-add-sent-message-event branch fromb37752e to34eb92aCompareDecember 28, 2020 13:59
@ismail1432
Copy link
ContributorAuthor

the failed test seems not related

@ismail1432ismail1432 changed the title[Notifier] add SentMessageEvent[Notifier] add SentMessageEvent and FailedMessageEventFeb 4, 2021
@ismail1432ismail1432force-pushed thenotifier-add-sent-message-event branch from091dff1 to9c1ccdeCompareFebruary 4, 2021 10:30
@ismail1432ismail1432force-pushed thenotifier-add-sent-message-event branch from394e2e4 to51941e0CompareFebruary 9, 2021 16:08
@ismail1432ismail1432force-pushed thenotifier-add-sent-message-event branch 3 times, most recently fromf463ebb to6af363aCompareFebruary 11, 2021 16:34
@OskarStarkOskarStark requested review fromjderusse and removed request forjderusseApril 6, 2021 12:34
@OskarStark
Copy link
Contributor

can you give us a final review here@jderusse ? Thanks

ismail1432 reacted with heart emoji

@ismail1432
Copy link
ContributorAuthor

friendly pump 😃

@OskarStarkOskarStark requested review fromfabpot andjderusse and removed request forjderusseJuly 13, 2021 08:04
@OskarStarkOskarStark changed the title[Notifier] add SentMessageEvent and FailedMessageEvent[Notifier] addSentMessageEvent andFailedMessageEventAug 4, 2021
Copy link
Member

@jderussejderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I see Travis tests, did you rebased the PR recently?

derrabus reacted with thumbs up emoji
@ismail1432ismail1432force-pushed thenotifier-add-sent-message-event branch fromc2531e7 todf0f304CompareAugust 5, 2021 00:37
Copy link
Member

@derrabusderrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, but we need to add an entry tosrc/Symfony/Component/Notifier/CHANGELOG.md.

OskarStark and ismail1432 reacted with thumbs up emoji
@ismail1432
Copy link
ContributorAuthor

LGTM, but we need to add an entry tosrc/Symfony/Component/Notifier/CHANGELOG.md.

Updated, let me know if it's not good.

@ismail1432ismail1432force-pushed thenotifier-add-sent-message-event branch from0a9af2b to9cef413CompareAugust 5, 2021 08:58
@chalasrchalasrforce-pushed thenotifier-add-sent-message-event branch from234621d to025256dCompareAugust 5, 2021 22:50
@chalasr
Copy link
Member

Thank you Smaine.

ismail1432 reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jderussejderussejderusse left review comments

@OskarStarkOskarStarkOskarStark approved these changes

@derrabusderrabusderrabus approved these changes

@chalasrchalasrAwaiting requested review from chalasr

@NyholmNyholmAwaiting requested review from Nyholm

@fabpotfabpotAwaiting requested review from fabpot

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

7 participants

@ismail1432@OskarStark@chalasr@jderusse@derrabus@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp