Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Fix NFS detection on macOs#39555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
jderusse commentedDec 18, 2020
| Q | A |
|---|---|
| Branch? | 5.2 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix#39552 |
| License | MIT |
| Doc PR | - |
chalasr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Does fix the FrameworkBundle test suite on my macbook 👍
Thanks!
Nyholm left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I also tried the steps to reproduce the bug defined in#39552, this patch will fix the issue.
mnocon commentedDec 18, 2020
If you need another data point: this PR solves the issue on my Mac 👍 |
derrabus commentedDec 18, 2020
Good catch, thanks Jérémy. |
alongosz commentedDec 18, 2020
Thanks@jderusse 🎉 |