Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] [Zulip] Host is required#39547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@OskarStark
Copy link
Contributor

@OskarStarkOskarStark commentedDec 18, 2020•
edited
Loading

QA
Branch?5.2
Bug fix?yes
New feature?no
Deprecations?no
Tickets---
LicenseMIT
Doc PR---

This bridge is the only one right now which cannot usedefault as host in the DSN, otherwise it would fall back to:

it could also not use:

protectedfunctiongetEndpoint(): ?string
{
return ($this->host ?:$this->getDefaultHost()).($this->port ?':'.$this->port :'');
}

Based on thedocumentation you must use your specific url like:
POST https://yourZulipDomain.zulipchat.com/api/v1/messages

Usinglocalhost would have weird side-effects.

Can you confirm this@phpfour , as you provided the bridge?

Todos after merge

  • adjust recipes with new DSN
  • update the docs

@carsonbotcarsonbot added this to the5.2 milestoneDec 18, 2020
@carsonbotcarsonbot changed the title[Notifier][Zulip] Host is required[Notifier] [Zulip] Host is requiredDec 18, 2020
@OskarStarkOskarStark deleted the fix-zulip-host-5.2 branchDecember 18, 2020 10:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

2 participants

@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp