Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Notifier] [Mattermost] Host is required#39545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| $options['channel_id'] =$message->getRecipientId() ?:$this->channel; | ||
| } | ||
| $endpoint =sprintf('https://%s/api/v4/posts',$this->host.($this->port ?':'.$this->port :'')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I moved it don, but the important part is to use$this->host instead of$this->getEndpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I used the "endpoint" as Mattermost could be run in a sub-folder stylehttps://example.com/mattermost/, thus resulting in its APIs being exposed ashttps://example.com/mattermost/api/v4/...`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you please show your full anonymous DSN ?
| where: | ||
| -`ACCESS_TOKEN` is your Mattermost access token | ||
| -`HOST` is your MATTERMOST url |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
url -> URL (or domain?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
But, a URL starts withhttp? 🤔
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Notifier/Bridge/Mattermost/MattermostTransport.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
fc547ab tocd5b480Comparenicolas-grekas commentedDec 18, 2020
Thank you@OskarStark. |
This PR was merged into the 5.1 branch.Discussion----------[Notifier] Update DSNRefssymfony/symfony#39545Commits-------facf002 Update DSN
| Q | A| ------------- | ---| Branch? | 5.x, but BC BREAK for experimental bridge| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | ---| License | MIT| Doc PR | ---Followssymfony#39545
| Q | A| ------------- | ---| Branch? | 5.x, but BC BREAK for experimental bridge| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | ---| License | MIT| Doc PR | ---Followssymfony#39545
| Q | A| ------------- | ---| Branch? | 5.x, but BC BREAK for experimental bridge| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | ---| License | MIT| Doc PR | ---Followssymfony#39545
| Q | A| ------------- | ---| Branch? | 5.x, but BC BREAK for experimental bridge| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | ---| License | MIT| Doc PR | ---Followssymfony#39545
| Q | A| ------------- | ---| Branch? | 5.x, but BC BREAK for experimental bridge| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | ---| License | MIT| Doc PR | ---Followssymfony#39545
| Q | A| ------------- | ---| Branch? | 5.x, but BC BREAK for experimental bridge| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | ---| License | MIT| Doc PR | ---Followssymfony#39545
Uh oh!
There was an error while loading.Please reload this page.
This bridge is the only one right now which cannot use
defaultas host in the DSN, otherwise it would fall back to:symfony/src/Symfony/Component/Notifier/Transport/AbstractTransport.php
Line 30 in090b425
it could also not use:
symfony/src/Symfony/Component/Notifier/Transport/AbstractTransport.php
Lines 83 to 86 in090b425
Based on thedocumentation you must use your specific url like:
your-mattermost-url.com/api/v4/...Using
localhostwould have weird side-effects.Can you confirm this@thePanz , as you provided the bridge?
friendly ping@seb37800, you fixed some bugs in this transport
Todos after merge