Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DomCrawler] Fix null namespace issue in Crawler#39474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@prosalov
Copy link
Contributor

QA
Branch?5.x
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#39277
LicenseMIT
Doc PR

In this caseisset may cause an issue if null value would be stored in$this->namespaces or$this->cachedNamespaces, but never fetched, as if condition would return false. This PR is for 5.x, because namespace caching was introduced recently (#39097).

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@derrabusderrabus added this to the5.x milestoneDec 11, 2020
@derrabus
Copy link
Member

Thank you@prosalov.

prosalov reacted with heart emoji

@derrabusderrabus merged commitd259c84 intosymfony:5.xDec 11, 2020
@prosalovprosalov deleted the fix-domcrawler-null-namespace-issue branchDecember 11, 2020 23:48
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jderussejderussejderusse approved these changes

@derrabusderrabusderrabus approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

[DomCrawler] Namespace-Prefixes with null value cached but not found

4 participants

@prosalov@carsonbot@derrabus@jderusse
[8]ページ先頭
©2009-2025 Movatter.jp