Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] [Free Mobile] Fix wrong scheme in mapping#39456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.1fromOskarStark:fix-mapping
Dec 12, 2020

Conversation

@OskarStark
Copy link
Contributor

@OskarStarkOskarStark commentedDec 11, 2020•
edited
Loading

QA
Branch?5.1
Bug fix?yes
New feature?no
Deprecations?no
Tickets---
LicenseMIT
Doc PR---

The scheme isfreemobile, notfree-mobile

For reference:

if ('freemobile' ===$scheme) {
returnnewFreeMobileTransport($login,$password,$phone,$this->client,$this->dispatcher);
}

@carsonbotcarsonbot added this to the5.1 milestoneDec 11, 2020
@carsonbotcarsonbot changed the title[Notifier][Free Mobile] Fix wrong scheme in mapping[Notifier] [Free Mobile] Fix wrong scheme in mappingDec 11, 2020
@OskarStarkOskarStarkforce-pushed thefix-mapping branch 2 times, most recently fromeea99c8 tob986a1aCompareDecember 11, 2020 13:28
Copy link
Member

@jderussejderusse left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 for consistency withgooglechat:// from thesymfony/google-chat-notifier component

OskarStark reacted with thumbs up emoji
@fabpot
Copy link
Member

Thanks for fixing this bug@OskarStark.

OskarStark reacted with thumbs up emoji

@fabpotfabpot merged commit7c7366a intosymfony:5.1Dec 12, 2020
This was referencedDec 18, 2020
@OskarStarkOskarStark deleted the fix-mapping branchJune 23, 2025 08:36
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@jderussejderussejderusse approved these changes

+1 more reviewer

@ogizanagiogizanagiogizanagi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

5 participants

@OskarStark@fabpot@jderusse@ogizanagi@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp