Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Notifier] [Discord] Fix exception message + test#39444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| if (\strlen($content) >2000) { | ||
| thrownewLogicException(sprintf('The subject length of"%s" transportmustbe less than2000 characters.',__CLASS__)); | ||
| thrownewLogicException('The subject length ofa Discord messagemustnot exceed2000 characters.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I am wondering if this should be an InvalidArgumentException 🧐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LengthException could be a good fit.
That's for 5.x anyway I suppose :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The fix itself is for 5.2, but we can use LengthException in 5.x, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
PR welcome now that it's merged.
| $content =$message->getSubject(); | ||
| if (\strlen($content) >2000) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
maybe time to move this to a private const?
also, we should consider using mb_strlen maybe? that'd require first checking if 2000UTF-8 chars are fine
last but not least, seehttps://support.discord.com/hc/en-us/community/posts/360031093812:
29/10/2020 edit: it's been kinda fixed. Now, if you type over the char limit discord will send the message as a TXT file. Not ideal but it's something.
this is worth a small investigation if anyone is up to trying with an actual Discord server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
See#39492
nicolas-grekas commentedDec 14, 2020
Thank you@OskarStark. |
Before this PR the message was wrong, "less than 2000" is not correct, it can have 2000 chars, but not more.