Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] Make use ofread_timeout in\RedisSentinel and\Redis#39431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Cache] Make use ofread_timeout in\RedisSentinel and\Redis#39431
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Both classes have an optional argument `$readTimeout` that can be set duringinitialization for `\RedisSentinel` and during `connect`/`pconnect`respectively.
carsonbot commentedDec 10, 2020
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
nicolas-grekas commentedDec 10, 2020
Good catch, thanks@ferrastas. |
…as-grekas)This PR was merged into the 4.4 branch.Discussion----------[Cache] fix setting "read_timeout" when using Redis| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -Being inspired by#39431Commits-------7acca31 [Cache] fix setting "read_timeout" when using Redis
This is a bugfix for#39363 a feature introduced in 5.x
As described in issue#39429,
\RedisSentinelaccepts an optional read timeout value during construction.read_timeoutis already part of the connection options, this PR just make use of it.