NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Messenger] Added more descriptive exception message when handling of a message failed#39423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:5.xfromloevgaard:4.4

Dec 10, 2020

Merged

[Messenger] Added more descriptive exception message when handling of a message failed#39423

nicolas-grekas merged 1 commit intosymfony:5.xfromloevgaard:4.4

Dec 10, 2020

Conversation

Copy link

Contributor

loevgaard commentedDec 10, 2020

Q	A
Branch?	4.4
Bug fix?	no (more of a patch thing)
New feature?	no
Deprecations?	no
License	MIT

I use Symfony Messenger extensively and I run into theHandlerFailedException from time to time. What bothers me is that the exception doesn't carry the name of the message that failed right there in the exception message.

Here is an example from Sentry:

As you can see I get the error message, but I have to look through all my messages (in different bundles etc) to find the sinner.

This PR adds the message name directly to the exception message.

loevgaard requested a review fromsroze as acode owner

December 10, 2020 10:04

carsonbot added Status: Needs Review Messenger labels

Dec 10, 2020

carsonbot added this to the4.4 milestone

Dec 10, 2020

Copy link

carsonbot commentedDec 10, 2020

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot