Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Notifier] [Discord] Make webhookId argument required#39413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
bykclk left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think you are right
mpiot commentedDec 9, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@OskarStark yes you're right, both are required: token and the chanel id, to use the webhook. |
| $this->assertSame(sprintf('discord://%s?webhook_id=%s',$host,$webhookId), (string)$transport); | ||
| } | ||
| publicfunctiontestCreateWithNoWebhookIdThrowsMalformed():void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
: void
fabpot left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
To be merged in 5.2
fabpot commentedDec 10, 2020
Thank you@OskarStark. |
Uh oh!
There was an error while loading.Please reload this page.
From the code perspective it looks like
$webhookIdcannot benullso I removed that and added a test.cc@mpiot