Since#36515 there are 2 caches dircacheDir andbuildDir. For BC reason both points to the same folders, but when app don't use the same folder, many thing are broken:
This PR fixes several issues introduces by the above PR:

some files are persisted in the wrong folder (App_KernelDevDebugContainerDeprecations.log,App_KernelDevDebugContainer.xml)
LoggerDataCollector looks into cache_dir, whileCompiler.log is written in build_dir andDeprecations.log were written in cache_dir before this PR
the logic that mirror cacheDir into buildDir at the end of CacheClearCommand does not make sens whencache_dir andbuild_dir are not identical.
Files generated in cacheDir are trashed at the end of CacheWarming (initial issue)

carsonbot added Status: Needs Review Bug labels

Dec 7, 2020

carsonbot added this to the5.2 milestone

Dec 7, 2020

jderusse force-pushed thefix-warmup branch 5 times, most recently from5b7dcc1 toe8e3aabCompare

December 8, 2020 16:56

Copy link

MemberAuthor

jderusse commentedDec 9, 2020

FYI test in red because test in FWB requires fix Kernel form this same PR (that's why in changed composer.json to 5.2.1)

nicolas-grekas approved these changes

Dec 11, 2020

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Dec 11, 2020

Copy link

Member

nicolas-grekas commentedDec 11, 2020

(the tests on Windows might need some love.)

jderusse force-pushed thefix-warmup branch frome8e3aab tob41a21cCompare

December 11, 2020 15:31

Copy link

MemberAuthor

jderusse commentedDec 11, 2020

(the tests on Windows might need some love.)

Fixed with my must favorite trick. Doing nothing... ^^

In fact, previous failure were very strange: I guess appveyor had FS issue
Failed to remove non-empty directory: Fixtures/var
Permission denied: Fixtures/var/cache
Failed to create dir: var/cache/resetting

Sylry mentioned this pull request

Dec 12, 2020

After manual deleting cache got errorEasyCorp/EasyAdminBundle#3568

Closed

Copy link

Member

nicolas-grekas commentedDec 14, 2020

(rebase needed)

Fix cache:clear with buildDir

ea68966

jderusse force-pushed thefix-warmup branch fromb41a21c toea68966Compare

December 14, 2020 17:15

jderusse commented

Dec 14, 2020

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Tests/Command/CacheClearCommand/CacheClearCommandTest.php

		}
		}

		class NoBuildDirKernelextends TestAppKernel

Copy link

MemberAuthor

jderusseDec 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could you have a look@chalasr ? Previous code can't work, becausekernel.build_dir is now needed to build the container (and now needed to initialize thecache:clear command).
I refactored the code t build a container and then remove the parameter from the dumped container.

alongosz mentioned this pull request

Dec 14, 2020

Bumped Symfony to v5.2 and prepared packages for 3.3 releaseezsystems/ezplatform#624

Merged

2 tasks

Copy link

alongosz commentedDec 14, 2020

Hey Guys, just wanted to let you know that this PR resolves ourblocker in Ibexa DXP preventing us from upgrading to Symfony 5.2. Thanks 👍

chalasr self-requested a review

December 15, 2020 07:10

carsonbot added Status: Needs Review and removed Status: Reviewed labels

Dec 15, 2020

chalasr approved these changes

Dec 15, 2020

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Dec 15, 2020

Copy link

Member

chalasr commentedDec 15, 2020

Thanks for fixing this bug@jderusse.

chalasr merged commita7fd98b intosymfony:5.2

Dec 15, 2020

chalasr mentioned this pull request

Dec 15, 2020

Container App_KernelDevDebugContainer.xml is no longer dumped#39240

Closed

This was referencedDec 15, 2020

Symfony 5.2 breaks JMS cacheschmittjoh/JMSSerializerBundle#823

Closed

[need feedback] issues regarding FileCache with Symfony 5.2 (beta)dustin10/VichUploaderBundle#1161

Closed

Copy link

Member

Kocal commentedDec 15, 2020

Thanks@jderusse ❤️ ❤️

Copy link

alongosz commentedDec 15, 2020

Thanks@jderusse 🎉
When can we expect a patch release / tag? :-)

Copy link

Member

derrabus commentedDec 15, 2020

By the end of the month, usually.

Copy link

lserwatka commentedDec 15, 2020

@derrabus we are launching new Ibexa DXP 3.3.0 on December 30th. We are eager to use Symfony 5.2 as all our tests are passing with this fix.

Could you make a Symfony 5.2.1 release before December 30th?

Copy link

Member

derrabus commentedDec 15, 2020

Could you make a Symfony 5.2.1 release before December 30th?

I'm pretty confident that 5.2.1 happens before Dec 30th. 😃 But please test against 5.2-dev in the meantime to make sure the changes work for you.

jderusse deleted the fix-warmup branch

December 15, 2020 11:49

Copy link

Contributor

mnapoli commentedDec 15, 2020

Thank you@jderusse!

Copy link

Contributor

Wirone commentedDec 16, 2020

First of all, thanks for the fix - I've encountered this problems in the project created with CLI binary few days ago and had to downgrade to 5.1 to continue working on it.

Personally I think that fixes like this one should be considered as hotfixes andreleased as soon as possible. Symfony 5.2.0 was released 16 days ago and is really unstable because of problems with cache (at least indev environment for development purposes). And now we hear that new version will be released at the end of the month which means for ~30 days straight really broken version will be installed by default bysymfony new ... and possibly upgraded to in already existing apps. That's... quite interesting 🤔