Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Remove translation data_collector BEFORE adding it to profiler#39350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:4.4froml-vo:fix_translator_datacollector_removed_too_lateSep 21, 2021
Merged
[FrameworkBundle] Remove translation data_collector BEFORE adding it to profiler#39350
fabpot merged 1 commit intosymfony:4.4froml-vo:fix_translator_datacollector_removed_too_lateSep 21, 2021
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
fabpot approved these changesSep 21, 2021
Member
fabpot commentedSep 21, 2021
Thank you@l-vo. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an order problem between
DataCollectorTranslatorPassandProfilerPass. CurrentlyDataCollectorTranslatorPassis registered afterProfilerPass. So ifdata_collector.translationis removed, it has already been added to the profiler and the compilation fails.The simplest approach seems to move
DataCollectorTranslatorPassbeforeProfilerPass.Use case: When I want to use
IdentityTranslator(for the test environment for instance) which doesn't implementTranslatorBagInterface.